lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

\compressFullBarRests should be renamed (issue 553750044 by address@hidd


From: lemzwerg
Subject: \compressFullBarRests should be renamed (issue 553750044 by address@hidden)
Date: Sat, 21 Mar 2020 11:27:06 -0700

LGTM, thanks!  I have some nits here and there, though.


https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely#newcode66
Documentation/changes.tely:66: @code{\compressFullBarRests} has been
renamed
s/renamed/renamed to/

https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely#newcode67
Documentation/changes.tely:67: @code{\compressEmptyMeasures}, to clear
up
s/, to clear up/to avoid/

https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely#newcode70
Documentation/changes.tely:70: 
Shouldn't \expandEmptyMeasures be mentioned as well?

https://codereview.appspot.com/553750044/diff/561590043/Documentation/de/notation/rhythms.itely
File Documentation/de/notation/rhythms.itely (right):

https://codereview.appspot.com/553750044/diff/561590043/Documentation/de/notation/rhythms.itely#newcode891
Documentation/de/notation/rhythms.itely:891: @funindex
expandEmptyMeasures
I suggest to fix the wrong index entries here: Only retain the ones with
a leading backslash.

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/rhythms.itely#newcode868
Documentation/notation/rhythms.itely:868: the note name uppercase
@code{R}.  Their duration is entered
For single-letter stuff I suggest to use `@example` instead of `@code`.

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/rhythms.itely#newcode888
Documentation/notation/rhythms.itely:888: number of measure-lengths;
therefore, some time signatures
I guess you refer to the `measure-length` property, right?  If this is
correct, then you should write `@code{measure-length}` instead.

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely#newcode864
Documentation/notation/staff.itely:864: Methods to quote other voices
and format cue notes
Maybe s/format/to format/.

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely#newcode1586
Documentation/notation/staff.itely:1586: @code{\compressMMRests} will
only apply to rests, and leave
no comma

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely#newcode1588
Documentation/notation/staff.itely:1588: a property setting, its syntax
differs slightly in that
no comma

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely#newcode1603
Documentation/notation/staff.itely:1603: rely on the
@code{@var{skipBars}} internal property, which is
why @var?

https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely#newcode1605
Documentation/notation/staff.itely:1605: @ref{The set command}.
ditto

https://codereview.appspot.com/553750044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]