[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use a hash table for the lexer keywords (issue 549920043 by address@
|
From: |
jonas . hahnfeld |
|
Subject: |
Re: Use a hash table for the lexer keywords (issue 549920043 by address@hidden) |
|
Date: |
Fri, 01 May 2020 04:22:12 -0700 |
On 2020/05/01 11:19:28, dak wrote:
> On 2020/05/01 11:15:29, hanwenn wrote:
> > 1) we can take dak's patch if you prefer. They're roughly equivalent
anyway.
> >
> > 2) I suppose ly:lexer-keywords was for editor modes, but it hasn't
been used
> for
> > that.
> > Updating the scripts to generate the modes is extra work, so I vote
for
> removing
> > it. If
> > nobody bothered in the last 13 years, it can't be that important.
>
> I'll make the removal a separate issue (and obviously commit) once the
"base
> patch" is in. That makes it possible to find, reference, and possibly
revert
> the removal in case that is ever wanted.
SGTM
https://codereview.appspot.com/549920043/