Re: [PATCH] Re: Duration dots and Bar lines on custom Staves.

[Joe Neeman]

On Sun, 2008-08-10 at 23:19 +0100, Neil Puttock wrote:
> 2008/8/10 Joe Neeman <address@hidden>:
> 
> > Ah, sorry, I evidently hadn't read your last email completely. The patch
> > you sent on the 7th looks pretty much OK to me. My only concern is that
> > you use real numbers instead of ints in line-positions; do we really
> > support that? If we do, it seems that dot-positions will be pretty
> > messed up in that case.
> 
> I didn't write the original code for this, but it only uses reals for
> comparisons when determining the highest and lowest lines on a custom
> stave; the result is rounded and cast as int when checking whether a
> grob is on a line.

I still think it's clearer to use ints all the way, but you can leave it
as it is.

> > Also, do we have regression tests for all this stuff?
> 
> ledger-lines-varying-staves.ly

Looks good!

Joe