code suggestions

[David Stocker]

Hello everyone.

Is there anyone on the list who wouldn't mind taking a look at some code 
and offering general suggestions on writing input files? I've now 
successfully typeset several piano scores and would like some feedback 
from experienced users about the structure of my .ly files. I'm still 
relatively new to LilyPond (but not to music typesetting). As a study, 
I'm setting some of the preludes and fugues from Dover's 1983 reprint of 
the Bach-Gesellschaft edition of Bach's /Well Tempered Clavier/. In 
particular, I'm after suggestions for the actual code structure and 
things I may do to make it simpler and more elegant. I'm already aware 
of any typesetting/collision issues in these draft copies and will 
consult the documentation (or user forum) for resolutions to typesetting 
issues.

Thanks in advance,

David Stocker

\version "2.11.59"

\include "english.ly"

\paper {
  #(set-paper-size "concert")
  }

#(set-global-staff-size 17.82)

\header {
  title = "Fugue 2, C Minor"
  composer = \markup { "J.S. Bach" \small "(1685-1750)" }
  tagline = ##f
  }

mBreak = { \break }

timeKey = {
  \time 4/4
  \key c \minor
  }

rightHand = {
  \tempo \markup { "Allegretto" }
    <<
      \voiceOne {
        \relative c'' {
        %1
        R1 |
        %2
        R1 |
        %3
        r8 g'16 fs g8 c, ef g16 fs! g8 a | \mBreak
        %4
        d,8 g16 fs g8 a c,16 d ef4 d16 c |
        %5
        bf8 ef16 d ef8 g, af f'16 ef f8 a, |
        %6
        bf8 g'16 f g8 b, c d16 ef f4~ | \mBreak
        %7
        f8 ef16 d c bf! af g f8 af' g f |
        %8
        ef8 d ef f b, c d b |
        %9
        c8 g'16 fs g8 d ef4 r8 e | \mBreak
        %10
        f8 f16 e f8 c d4 r8 d |
        %11
        ef!8 ef16 d ef8 bf c ef16 d ef8 f |     
        }
}
\\
       \voiceTwo {
         \relative c'' {
         %1
         r8 c16 b c8 g af c16 b c8 d |
         %2
         g,8 c16 b c8 d f,16 g af4 g16 f |
         %3
         ef16 c' b a g f! ef d c8 ef' d c |
         %4
         bf!8 a bf c fs, g a fs |
         %5
         g4 r16 c, d ef f g af8~ af16 d, ef f |
         %6
         g16 a bf8~ bf16 ef, f g af g f ef d8 c'16 b |
         %7
         c4 r4 r8 f ef d |
         %8
         r8 af g f g f16 ef f8 d |
         %9
         g4 r8 b c c16 b c8 g |
         %10
         af4 r8 a bf bf16 a bf8 f |
         %11
         g4 r8 g af! af g f |
         }
        }
       >>
  
  \oneVoice {
    \relative c'' {
      %12
      bf8 ef16 d ef8 f af,16 bf c4 bf16 af | \mBreak
      %13
      g16 ef f g af bf c d ef d c d ef f g a |
      %14
      \stemDown bf16 \stemUp f, g af \stemNeutral bf c d e f ef d ef f g a b |
      }
    }
<<
  \voiceOne {
    \relative c''' {
      %15
      c8 b16 a g f ef d c8 ef d c | \mBreak
      %16
      bf8 a bf c fs, g a fs |
      %17
      g8 d'16 c d8 r r e16 d e8 r |
      %18
      r8 fs16 e fs8 r r g,16 f! g8 r | \mBreak
      %19
      r8 a16 g a8 r r b16 a b8 r |
      %20
      r8 c16 b c8 g af c16 b c8 d |
      %21
      g,8 c16 b c8 d f,16 g af4 g16 f | \mBreak
      %22
      ef8 c'16 b c8 g af4 r8 a |
      %23
      bf8 b16 a bf8 f g4 r8 g8~ |
      %24
      g8 af16 bf c b c af f2~ | \mBreak
      %25
      f8 d'16 c d8 f, ef ef'16 d ef8 g, |
      %26
      f8 f'16 ef f8 af, g16 f' ef d c b a g |
      %27
      c8 f ef d r af g f | \mBreak
      %28
      g8 f16 ef f8 d af' f r a |
      %29
      b8 c f,16 ef d c c8 c'16 b c8 g |
      %30
      af8 c16 b c8 <af b d> g c16 b c8 d |
      %31
      f,16 g af4 g16 f <g, c e>2 \bar "|."
      }
    }
  \\
  \voiceTwo {
    \relative c' {
      %15
      \change Staff = "leftHand" \stemUp g8 \change Staff = "rightHand" 
\stemDown g'16 fs g8 c, ef g16 fs g8 a |
      %16
      d,8 g16 fs g8 a c,16 d ef4 d16 c |
      %17
      bf8 r r16 d e fs g a bf8~ bf16 e, f g |
      %18
      a16 bf c8~ c16 fs, g a bf8 ef,!16 d ef8 g, |
      %19
      af8 f'16 ef f8 a, bf g'16 f g8 b, |
      %20
      c16 f ef d s4 \change Staff = "leftHand" \stemUp f,8 \change Staff = 
"rightHand" \stemDown af' g f |
      %21
      ef8 d ef f b, c d b |
      %22
      c4 r8 e f f16 e f8 c |
      %23
      d4 r8 d ef ef16 d ef8 bf |
      %24
      c2~ c8 d16 ef f ef f d |
      %25
      b8 r r b c r r ef |
      %26
      d8 r r f~ f r r f |
      %27
      ef8 af g f ef d ef f |
      %28
      b,8 c d b b c r c |
      %29
      f16 d ef c~ c8 b c4 r8 e |
      %30
      f4 r8 f f ef16 d ef8 <f af> |
      %31
      <b, d>8 r8 <b d>8 r s2 |
      }
    }
  >>
}

leftHand = {
  \relative c' {
    \oneVoice
    %1
    R1 |
    %2
    R1 |
    %3
    R1 |
    %4
    R1 |
    %5
    R1 |
    %6
    R1 |
    %7
    r8 c16 b c8 g af c16 b c8 d |
    %8
    g,8 c16 b c8 d f,16 g af4 g16 f |
    %9
    ef16 c' b a g f ef d c d ef d c bf af g |
    %10
    \stemUp f16 \stemDown bf' af g \stemNeutral f ef d c bf c d c bf af g f |
    %11
    \stemUp ef16 \stemDown af' g f \stemNeutral ef df c bf \stemUp af8 
\stemDown c' bf af |
    
    }
<<
  \voiceOne {
    \relative c' {
      %12
      r8 af bf c r8 af16 g af8 f |
      %13
      bf8 c bf af bf g f ef |
      %14
      f8 df' c bf c af g f |
      }
    }
\\
  \voiceTwo {
    \relative c' {
      %12
      g8 f g af d, c f d |
      %13
      ef8 af g f g ef d c |
      %14
      d8 bf' af g af f ef d! |
      }
    }
  >>
  \oneVoice {
    \relative c {
      %15
      ef8 r8 r4 r8 c bf a |
      %16
      r8 ef' d c d c16 bf c8 d |
      %17
      g,8 bf'16 a bf8 d, ef c'16 bf c8 e, |
      %18
      f8 d'16 c d8 fs, g4 r16 g, a b |
      %19
      c16 d ef8~ ef16 a, bf c d ef f8~ f16 b, c d |
      }
    }
<<
  \voiceOne {
    \relative c' {
      %20
      s4 c16 bf af g s2 |
      }
    }
\\
  \voiceTwo {
    \relative c {
      %20
      ef8 r r e f f, ef! d |
      }
    }
>>
  \oneVoice {
    \relative c {
      %21
      r8 af g f g f16 ef f8 g |
      %22
      c16 d ef d c bf a g \stemUp f \stemDown bf' af g \stemNeutral f ef d c |
      %23
      bf16 c d c bf a g f \stemUp ef \stemDown af' g f \stemNeutral ef d c bf |
      %24
      af16 bf c bf af g f ef \stemUp d \stemDown g' f ef \stemNeutral d c b a |
      %25
      g4 r r16 g a b c d ef f |
      %26
      g16 f af g f ef d c b8 c16 b c8 g |
      %27
      af8 c16 b c8 d g, c16 b c8 d |
      %28
      f,16 g af4 g16 f ef4 r8 ef' |
      %29
      d c g' g, <c, c'>2~ |
      %30
      <c c'>1~ |
      %31
      <c c'>1
      }
    }
  }

\score {
  <<
    \new PianoStaff <<
      \new Staff = "rightHand" <<
        \timeKey
        \clef "treble"
        \new Voice { \rightHand }
        >>
      \new Staff = "leftHand" <<
        \timeKey
        \clef "bass"
        \new Voice { \leftHand }
        >>
      >>
    >>

  \midi { }

  \layout { }
}

\version "2.11.59"

\include "english.ly"

\paper { 
#(set-paper-size "concert")

}

#(set-global-staff-size 17.82)

\header {
  title = "Prelude 2, C Minor"
  composer = \markup { "J.S. Bach" \small "(1685-1750)" }
  tagline = ##f
}

mBreak = { \break }

timeKey = {
  \time 4/4
  \key c \minor }

rightHand = {
  \tempo \markup { "Allegro" }
  \relative c'' {
    %1
    c16 ef, d ef c ef d ef c' ef, d ef c ef d ef |
    %2
    af16 f e f c f e f af f e f c f e f |
    %3
    b16 f ef! f d f ef f b f ef f d f ef f | \mBreak
    %4
    c'16 g f g ef g f g c g f g ef g f g |
    %5
    \stemUp ef'16 af, g af ef af g af ef' af, g af ef af g af |
    %6
    \stemNeutral d16 fs, e fs d fs e fs d' fs, e fs d fs e fs | \mBreak
    %7
    d'16 g, fs g d g fs g d' g, fs g d g fs g |
    %8
    c16 e, d e c e d e c' e, d e c e d e |
    %9
    c'16 f, e f c f e f c' f, e f c f e f | \mBreak
    %10
    bf16 f ef! f d f ef f bf f ef f d f ef f |
    %11
    bf16 g f g ef g f g bf g f g ef g f g |
    %12
    af16 g f g ef g f g af g f g ef g f g | \mBreak
    %13
    af16 d, c d bf d c d af' d, c d bf d c d |
    %14
    g16 bf, af bf ef bf af bf g' bf, af bf ef bf af bf |
    %15
    f'16 c bf c a c bf c f c bf c a c bf c | \mBreak
    %16
    f16 d c d b d c d f d c d b d c d |
    %17
    f16 d c d b d c d f d c d b d c d |
    %18
    ef16 c b c g c b c ef c b c g c b c |
    %19
    f,16 ef' d ef f ef d ef f, ef' d ef f ef d ef |
    %20
    fs,16 c' b c ef c b c fs, c' b c ef c b c |
    %21
    ef16 c b c g c b c ef c b c g c b c | \mBreak
    %22
    fs16 c b c a c b c fs c b c a c b c |
    %23
    g'16 c, b c d c b c g' c, b c d c b c |
    %24
    af'16 c, b c d c b c af' c, b c d c b c | \mBreak
    %25
    s8. \change Staff = "leftHand" \stemUp f,16 af f e f b f d' b af f e! f |
    %26
    s8. g16 c g fs g \change Staff = "rightHand" \stemDown ef' c g' ef \change 
Staff = "leftHand" \stemUp c af g af |
    %27
    s8. \change Staff = "rightHand" c16 ef c b c fs c a' fs ef c b! c | \mBreak
    %28
    \tempo \markup { "Presto" }
    \stemNeutral r16 d' c d ef c b c a c b! c d b a b |
    %29
    g16 b a b c a! g a fs a g a b! g fs g |
    %30
    \stemUp d16 \stemNeutral g' f! g af f ef f d f ef f g ef d ef | \mBreak
    %31
    \stemUp c16 ef d ef f d c d b d c d ef c b c |
    %32
    g16 c b c af f' ef f g, ef' d ef f, d' c d |
    %33
    ef,16 c' b c af f ef f g ef d ef f d c d | \mBreak
    }
  << \voiceOne {
    \relative c' {
      \tempo \markup { "Adagio" }
      %34
      <e>8~ \arpeggio [e32 c d e] f64 g af bf c bf af g f16 g32 e! <f>8~ 
\arpeggio \mordent [f32 g f e!] f [g af g f64 ef d ef f d ef f] |
      }
    }
\\
     \voiceTwo {
       \relative c'{
         %34
         <c>4 \arpeggio s4 <c>4 \arpeggio s4 |
         }
       }
     >>
  \oneVoice {
    \relative c' {
      \tempo \markup { "Allegro" }
      %35
      s1 | \mBreak
      %36
      s1 |
      %37
      s1 |
      %38
      \change Staff = "leftHand" af16 \change Staff = "rightHand" \stemUp c f d 
f af c b c g f d e4 \fermata | \bar "|."
      }
    }
  }

  

leftHand = {
  \relative c {
    %1
    c16 g' f g ef g f g c, g' f g ef g f g |
    %2
    c,16 af' g af f af g af c, af' g af f af g af |
    %3
    c,16 af' g af f af g af c, af' g af f af g af |
    %4
    c,16 ef d ef g ef d ef c ef d ef g ef d ef |
    %5
    c16 c' bf c af c bf c c, c' bf c af c bf c |
    %6
    c,16 a' g a fs a g a c, a' g a fs a g a |
    %7
    bf,16 bf' a bf g bf a bf bf, bf' a bf g bf a bf |
    %8
    bf,16 g' f g e g f g bf, g' f g e g f g |
    %9
    af,16 af' g af f af g af af, af' g af f af g af |
    %10
    \stemDown af,16 d c d f d c d af d c d f d c d |
    %11
    g,16 ef' d ef g ef d ef g, ef' d ef g ef d ef |
    %12
    \stemNeutral c16 ef d ef af ef d ef c ef d ef af ef d ef |
    %13
    d16 f ef f af f ef f d f ef f af f ef f |
    %14
    ef16 g f g af g f g ef g f g af g f g |
    %15
    ef16 a g a f a g a ef a g a f a g a |
    %16
    d,16 f ef f af! f ef f d f ef f af f ef f |
    %17
    c16 f e f af f e f c f e f af f e f |
    %18 %% the dover edition contains a mistake on beat 3 of this bar
        %% and actually has printed 'bf' %%
    c ef! d ef f ef d ef c ef d ef f ef d ef |
    %19
    af,16 c b c d c b c af c b c d c b c |
    %20
    \stemUp a16 ef' d ef c ef d ef a, ef' d ef c ef d ef |
    %21
    \stemDown g,16 ef' d ef f ef d ef g, ef' d ef f ef d ef |
    %22
    g,16 ef' d ef c ef d ef g, ef' d ef c ef d ef |
    %23
    g,16 ef' d ef f ef d ef g, ef' d ef f ef d ef |
    %24
    g,16 ef' d ef f ef d ef g, ef' d ef f ef d ef |
    %25
    \stemDown g,16 b d s16 s2. |
    %26
    g,16 c ef s16 s2. |
    %27
    g,16 a fs' s16 s2. |
    %28
    g,1~ |
    %29
    \stemUp g16 \stemDown d'' c d ef c b c a c b! c d b a b |
    %30
    g b a b c af g af f a g a b! g f g |
    %31
    \stemUp ef16 \change Staff = "rightHand" \stemDown g' f g af f ef f d f ef 
f g ef d ef |
    %32
    c16 ef d ef f d c d ef c b c d \change Staff = "leftHand" \stemUp b a b
    %33
    \stemNeutral c ef d ef f, d' c d ef, c' b c d, b'! a b |
    }
  << \voiceOne {
    \relative c' {
      %34
       <bf!>4 \arpeggio s4 <af>4 \arpeggio s4 |
      %35
      b8. d,16 f af g f b! f d' f, b af g f |
      %36
      e16 df' bf! g c af f af g bf g e! af f d! f |
      %37
      e16 g e c f d b d r8 r16 d e! g bf! g |
      %38
      s1 |
      }
    }
\\
     \voiceTwo {
       \relative c {
         %34
         <c>4 \arpeggio r4 <c>4 \arpeggio r4 |
         %35
         r16 c,8.~ c4~ c2 |
         %36
         s1 |
         %37
         s2 c2~ |
         %38
         c1 |
         }
       }
\\
     \voiceThree {
       \relative c' {
         %34
         <g>4 \arpeggio r4 <f>4 \arpeggio r4 |
         %35
         \mergeDifferentlyDottedOn s16  c, \tieDown b'8~ b4~ b2 |
         %36
         s1 |
         %37
         s2 \voiceFour b16\rest g c8~ c4~ |
         %38
         \shiftOff c1
         }
       }
     >>
  }
    
   
\score { 
  <<
    \new PianoStaff <<
      \set PianoStaff.connectArpeggios = ##t
      \new Staff = "rightHand" <<
      \timeKey
      \clef "treble"
      \new Voice { \rightHand }
      >>
      \new Staff = "leftHand" <<
        \timeKey
        \clef "bass" { \leftHand }
        >>
      >>
    >>
  \midi { }

  \layout { }
 }