Re: How to include a file/definition temporarily?

[Carl Sorensen]

On 9/24/10 4:37 AM, "Patrick Schmidt" <address@hidden> wrote:

> Carl,
> 
> first of all thank you very much for your patch! I had a quick look
> at it on Rietveld and I'm stunned. I don't know how you managed to
> get all of this done in such a short period of time.

You're welcome.  When one is really familiar with the code (I'm the original
author of this stuff), it doesn't usually take long to make changes.

> Am 24.09.2010 um 07:12 schrieb Carl Sorensen:
> 
>> Patrick,
>> 
>> I've loaded a patch on Rietveld that allows user-defined fretboard
>> tables,
>> so you can include two different tables and switch between them at
>> will.
>> 
>> If you don't build from git, you'll need to wait for a release.  If
>> you do,
>> you can download the patch set now.
> I think I can build from git (VirtualBox/LilyBuntu ond Mac OS 10.4).
> At least IIRC I managed it once. As I don't want to change my running
> system I can't use the current version of Virtual Box but I hope this
> won't be a problem. At least I will have to increase my RAM. (At the
> moment I only have 1 GB for both OSs). And I'll have to get used to
> LilyBuntu. So it might take some time for me to test your patch.

Don't feel any pressure to test my patch.  I just wanted you to know it was
available because you had made the feature request.  It will get added to
git relatively soon, and there should be a new release coming soon as well.

> I 
> actually haven't got a clue what I have to do with your patch after
> downloading it.

You would download the patch, then apply it using

git apply

Then you'd rebuild lilypond with

make


> Or is it already part of the current devel version?

It's not yet part of the git repository.  It's posted for comment on
Rietveld.  Once it's reviewed by others it will be pushed to git.  At that
point anybody who pulls the code using git will have it.

It will only become part of the current devel version when a new devel
version is released.
 
> This might be a stupid question but I didn't find any information on
> this in the manuals.

I guess we should put a section on Reviewing Patches in the CG.

> 
> Thanks again,
> patrick
> 
> P.S.: While working on alternative fretboard tables I think I found a
> better workaround for triad inversions in chord mode...

I'm anxious to see what you have in mind!

Thanks,

Carl