[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tuplet numbers on kneed beams - David's function stopped working
From: |
address@hidden |
Subject: |
Re: tuplet numbers on kneed beams - David's function stopped working |
Date: |
Tue, 16 Oct 2012 22:04:57 +0300 |
On 16 oct. 2012, at 18:49, Janek Warchoł <address@hidden> wrote:
> On Tue, Oct 16, 2012 at 2:20 PM, David Kastrup <address@hidden> wrote:
>> commit d8dfa746ead381a80901106b9c9b079dc9b5d004
>> Author: Mike Solomon <address@hidden>
>> Date: Fri Aug 31 09:27:17 2012 +0200
>>
>> Uses a heuristic to determine if chord tremolos collide with accidentals.
>>
>> This heuristic makes several assumptions about when a chord tremolo
>> will collide with accidentals. It must be between whole notes, it
>> must be in the staff, and it must be an ascending major third or lower.
>> The heuristic is entirely contained in
>> Beam::whole_note_close_chord_tremolo,
>> which should be modified if other cases involving chord tremolos arise.
>>
>>
>> I just love it when only loosely related API and functionality changes
>> are sneaked in with other stuff.
>
> bang.
> Well, it's not only Mike's fault - we failed to provide any feedback:
> http://codereview.appspot.com/6485070
> Anyway, thanks for finding the cause of the problem and the solution!
>
> Janek
Hey all,
Just saw this. Is all that needs to happen a convert-ly rule? I can likely do
that next week. Otherwise, if it's a more involved bug, we can look into
reverting the commit and I'll investigate it whenever I have time.
Cheers,
MS
- tuplet numbers on kneed beams - David's function stopped working, Janek Warchoł, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working, Phil Holmes, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working, David Nalesnik, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working, Thomas Morley, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working, David Kastrup, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working, David Nalesnik, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working, Janek Warchoł, 2012/10/16
- Re: tuplet numbers on kneed beams - David's function stopped working,
address@hidden <=
- Re: tuplet numbers on kneed beams - David's function stopped working, Janek Warchoł, 2012/10/23
- Re: tuplet numbers on kneed beams - David's function stopped working, David Nalesnik, 2012/10/16