Re: [feature request:] fret diagrams with fingering indications and additional text

[Thomas Morley]

2015-11-08 14:52 GMT+01:00 pls <address@hidden>:
> Thomas Morley <address@hidden> writes:
>
>> 2015-11-08 12:23 GMT+01:00 pls <address@hidden>:
>
>>> Hi Harm,
>>>
>>> I finally managed to test your code and I really, really like it!  I
>>> especially like the option to
>>> turn the annotations on and off.
>>
>> Glad you like it.
>>
>> Ofcourse it's not in the source atm.
>> And there's the (long-standing) problem that we have a plethora of
>> properties in fret-diagram-interface, far too much.
>> This code even adds another one.
>
> I actually feel that some properties/options are still missing in the
> fret-diagram-interface!

Well, though how many should be added? It's difficult not to loose
oversight even now.

> For example there is no option to append some
> text to the fret label value to achieve something like that: "5 fr."

Yep, that's not possible right now, if I remember correctly.

> I
> haven't worked out how to change the thickness of the barre indication...

That should be possible, lemme have a look.

>
>> Not all of them are documented in a useful manner.
> Well, at least some bits and pieces are missing. Quite often I detect
> things more by trial and error...
>
>> I've the feeling we should rewrite the whole thingy...
>> Not that I'd have a good idea how to do it or the time to think about it at 
>> all.
> Do you mean rewriting the fret-diagram-interface and or it's
> documentation?

rewriting the whole fret-diagram-interface ^^

>
>
>>> Correct me if I'm wrong but I think that some (or all?) of your recent
>>> improvements have not been documented in the Notation Reference.  I'd
>>> volunteer for this job.
>>
>> Honestly, I did not always keep track what's documented and what's not, 
>> though:
>>
>> Entering text instead of finger-indications is an old feature (but
>> wasn't documented for ages)
>
> I used to use that feature with
> terse-syntax a couple of years ago until it stopped working. But I wasn't 
> aware back then that it was also
> available in verbose-syntax.
>
>> Setting individual parentheses, colors, parentheses-colors is
>> documented, sort of...
>>
>> http://www.lilypond.org/doc/v2.19/Documentation/notation/common-notation-for-fretted-strings#fret-diagram-markups
>>
>> Would be great if you could work on improving this section, I'm not
>> very good in writing docs ...
>
> I will give it a try but it will take some time.

Thanks!

>
> Thanks!
> Patrick
>
> BTW: I know that your changes to fret-diagram.scm are experimental.  I
> just wanted to let you know that a chord with a barre
> indication caused the following error:
>
> Interpreting music...[8][16]
> Preprocessing graphical 
> objects.../lilypond.git/build/out/share/lilypond/current/scm/fret-diagrams.scm:612:9:
>  In procedure make-bezier-sandwich-stencil in expression 
> (make-bezier-sandwich-stencil bezier-list (* size bezier-thick) ...):
> /lilypond.git/build/out/share/lilypond/current/scm/fret-diagrams.scm:612:9: 
> Wrong number of arguments to #<procedure make-bezier-sandwich-stencil (coords 
> thick)>

In a recent patch I changed make-bezier-sandwich-stencil, so this is
not surprising, if you tried to compile it with a build from master.
Therefore my test-file stated "2.19.29" ;)
Maybe I have time tomorrow evening to apply the changes to a recent
fret-diagram.scm

>
> Compilation exited abnormally with code 1 at Sun Nov  8 14:16:37
> in a separate branch of my lilypond.git repository
>
> (I'm testing in a separate branch of the lilypond.git repository and made a 
> backup copy of
> fret-diagram.scm in addition, so that's not a problem for me.)
>
> If you can't reproduce the error I will try to cook up a minimal example.

Cheers,
  Harm