Re: [Linphone-developers] Problem with an infinite loop in bcg729 codec

[BOITEUX, FREDERIC]

        Hi Johan,

Thanks for your quick reply !

About the test suite, you’re correct, I didn’t had the latest pattern archive 
(I had an obsolete URL which didn’t work anymore and found somewhere an 
outdated archive). With the latest sources and patterns, all tests went fine 😊.

About ASAN errors, I still got errors, I share with you the whole options I use 
: I build the test suite with the following command :

(mkdir build_testASAN && cd build_testASAN && cmake -D ENABLE_TESTS=YES 
-DCMAKE_SKIP_INSTALL_RPATH=ON  -D CMAKE_C_FLAGS:STRING="${CMAKE_C_FLAGS} 
-fsanitize=address -fno-omit-frame-pointer  -fno-common -fsanitize=undefined 
-fsanitize=shift -fsanitize=integer-divide-by-zero -fsanitize=unreachable 
-fsanitize=vla-bound -fsanitize=signed-integer-overflow 
-fsanitize=bounds-strict -fsanitize=object-size -fsanitize=nonnull-attribute 
-fsanitize=returns-nonnull-attribute -fsanitize=bool -fsanitize=enum" .. && 
make)
[I'm running on Debian 10 Buster]

To be able to fully compile test suite, I had to fix some trivial warnings in 
some test programs, you'll find them attached to this e-mail, feel free to 
include them in your source tree.

 I run tests with :
(cd build_testASAN/test && ./testCampaignAll 2>&1|tee testCampaignAll.log)

The ASAN system produces a lot of logs, but I still get errors, like :

…
Test fixedCodebookSearch bloc
… lot of ASAN log…
…/bcg729.git/src/fixedCodebookSearch.c:211:28: runtime error: left shift of 
negative value -1
…/bcg729.git/src/fixedCodebookSearch.c:212:28: runtime error: left shift of 
negative value -1
…/bcg729.git/src/fixedCodebookSearch.c:213:28: runtime error: left shift of 
negative value -1
…/bcg729.git/src/fixedCodebookSearch.c:210:28: runtime error: left shift of 
negative value -1
  ... Pass

And when counting these errors  for the whole test suite, I get :
$ grep error testCampaignAll.log| wc -l
574

I'm not sure about the gravity/impact of these messages…


About the endless loop, many thanks for the fix, I've also tested it 
successfully, it's perfect 😊 !


        With regards,
        Frédéric Boiteux - Odigo IVR

This message contains information that may be privileged or confidential and is 
the property of the Capgemini Group. It is intended only for the person to whom 
it is addressed. If you are not the intended recipient, you are not authorized 
to read, print, retain, copy, disseminate, distribute, or use this message or 
any part thereof. If you receive this message in error, please notify the 
sender immediately and delete all copies of this message.

fix_warnings_in_test_suite.patch
Description: fix_warnings_in_test_suite.patch