Re: [Linphone-developers] [From External Source] reserved identifier violation

[Nadejda Georgieva]

I'm Ok with what
day you choose. 

Nadia 



From:
       "Markus
Elfring" <Markus.Elfring@web.de>
To:
       linphone-developers@nongnu.org
Date:
       12/17/2022
05:09 PM
Subject:
       [From
External Source] [Linphone-developers] reserved identifier violation
Sent
by:        linphone-developers-bounces+ngeorgieva=dkaccess.com@nongnu.org

---

Hello,

I would like to point out that identifiers like the following do not fit
to
the expected naming convention of the C++ language standard.

* __LINPHONE_CALL_PARAMS_H__
  https://gitlab.linphone.org/BC/public/liblinphone/-/blob/a33b4d6f5f4b37612e046abc09beecfb4d74975a/include/linphone/call_params.h#L22

* __TUNNEL_CLIENT_MANAGER_H__
  https://gitlab.linphone.org/BC/public/liblinphone/-/blob/a33b4d6f5f4b37612e046abc09beecfb4d74975a/coreapi/TunnelManager.hh#L11


Would you like to adjust your selection for unique names?
https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

Regards,
Markus


_______________________________________________
Linphone-developers mailing list
Linphone-developers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/linphone-developers