[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 7837f36 5/6: Fix defect introduced 20050114T1
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 7837f36 5/6: Fix defect introduced 20050114T1947Z: function call with no effect |
Date: |
Wed, 12 Aug 2020 18:48:00 -0400 (EDT) |
branch: master
commit 7837f36d6f9249439cffa4eb633ab89c8f76b4d2
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Fix defect introduced 20050114T1947Z: function call with no effect
Although this defect was introduced 20050114T1947Z into CVS, it comes
from an original file predating the lmi epoch, which contained:
round_interest_rate(tiered_load_amd);
which calculates and discards the rounded value of its (unaffected)
argument.
This change has no effect on any of lmi's 1500 or so regression tests,
but presumably some ancient product reaches this obscure corner of the
code. Gave force to the original intention, which seems reasonable
enough: a dynamic separate-account load is in the nature of a decrement
to the interest rate.
The actual resulting fund increment, SepAcctLoad, has never been, but
should always have been, and soon will be, rounded.
---
ihs_avmly.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ihs_avmly.cpp b/ihs_avmly.cpp
index 0d748aa..e81cb58 100644
--- a/ihs_avmly.cpp
+++ b/ihs_avmly.cpp
@@ -1972,7 +1972,7 @@ void AccountValue::TxTakeSepAcctLoad()
YearsSepAcctLoadRate += stratified_load;
YearsSepAcctLoadRate += tiered_comp;
YearsSepAcctLoadRate =
i_upper_12_over_12_from_i<double>()(YearsSepAcctLoadRate);
- round_interest_rate()(YearsSepAcctLoadRate);
+ YearsSepAcctLoadRate = round_interest_rate()(YearsSepAcctLoadRate);
}
SepAcctLoad = YearsSepAcctLoadRate * AVSepAcct;
- [lmi-commits] [lmi] master updated (26865ea -> e166864), Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 97a7a35 1/6: Improve variable names, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master e166864 6/6: Round interest credit to separate account, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 8667bda 2/6: Add a rounding rule for minutiae, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 363ea40 3/6: Round specified-amount load, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 785e6f4 4/6: Round rider charges, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 7837f36 5/6: Fix defect introduced 20050114T1947Z: function call with no effect,
Greg Chicares <=