[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] valyuta/002 9419729 4/7: Do away with unused return
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] valyuta/002 9419729 4/7: Do away with unused return value #4 |
Date: |
Sun, 20 Sep 2020 18:51:23 -0400 (EDT) |
branch: valyuta/002
commit 941972919d548721ad8ed7668d3091f56204a617
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Do away with unused return value #4
---
account_value.hpp | 2 +-
accountvalue.cpp | 7 ++-----
ihs_acctval.cpp | 7 ++-----
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/account_value.hpp b/account_value.hpp
index 86041be..89e957a 100644
--- a/account_value.hpp
+++ b/account_value.hpp
@@ -132,7 +132,7 @@ class LMI_SO AccountValue final
LedgerVariant & VariantValues ();
currency RunOneCell (mcenum_run_basis);
- currency RunOneBasis (mcenum_run_basis);
+ void RunOneBasis (mcenum_run_basis);
void RunAllApplicableBases ();
void InitializeLife (mcenum_run_basis);
void FinalizeLife (mcenum_run_basis);
diff --git a/accountvalue.cpp b/accountvalue.cpp
index a936d7c..407ed17 100644
--- a/accountvalue.cpp
+++ b/accountvalue.cpp
@@ -148,21 +148,18 @@ void AccountValue::RunAV()
}
//============================================================================
-currency AccountValue::RunOneBasis(mcenum_run_basis TheBasis)
+void AccountValue::RunOneBasis(mcenum_run_basis TheBasis)
{
- currency z;
if(Solving)
{
// IHS !! Isn't this unreachable?
throw std::logic_error("This line had seemed to be unreachable.");
// LMI_ASSERT(TheBasis corresponds to
yare_input_.SolveExpenseGeneralAccountBasis);
-// z = Solve();
}
else
{
- z = RunOneCell(TheBasis);
+ RunOneCell(TheBasis);
}
- return z;
}
//============================================================================
diff --git a/ihs_acctval.cpp b/ihs_acctval.cpp
index b23e48e..3bfbf71 100644
--- a/ihs_acctval.cpp
+++ b/ihs_acctval.cpp
@@ -226,7 +226,7 @@ void AccountValue::SetGuarPrem()
}
//============================================================================
-currency AccountValue::RunOneBasis(mcenum_run_basis a_Basis)
+void AccountValue::RunOneBasis(mcenum_run_basis a_Basis)
{
if
( !BasicValues::IsSubjectToIllustrationReg()
@@ -239,20 +239,17 @@ currency AccountValue::RunOneBasis(mcenum_run_basis
a_Basis)
;
}
- currency z {};
if(Solving)
{
// Apparently this should never be done because Solve() is called in
// RunAllApplicableBases() .
// TODO ?? Isn't this unreachable?
// LMI_ASSERT(a_Basis corresponds to
yare_input_.SolveExpenseGeneralAccountBasis);
-// z = Solve();
}
else
{
- z = RunOneCell(a_Basis);
+ RunOneCell(a_Basis);
}
- return z;
}
//============================================================================
- [lmi-commits] [lmi] valyuta/002 updated (18ab8be -> 5fb74f1), Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 18e7015 1/7: Do away with unused return value #1, Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 2f32980 5/7: Do away with unused return value #5, Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 89b2c7a 6/7: Fix incorrect documentation, Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 5fb74f1 7/7: Prefer cents() to m(), Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 5447866 2/7: Do away with unused return value #2, Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 96435be 3/7: Do away with unused return value #3, Greg Chicares, 2020/09/20
- [lmi-commits] [lmi] valyuta/002 9419729 4/7: Do away with unused return value #4,
Greg Chicares <=