Re: [Ltib] Special tag localdir_nobuild causes LTIB to go to the config screen.

[aaron]

Hi Stuart.  Actually, your previous attempt to fix this by avoiding the
call to `./ltib -m clean` in the case of localdir_nobuild in the
bin/Ltibrelease.pm script was necessary as well.  The way it was before
caused my config/platform/mpc8349itx/.config file to be copied to
config/platform/mpc8349itx/.config.bak, and the new .config file had

# CONFIG_PKG_KERNEL_LEAVESRC is not set

instead of

CONFIG_PKG_KERNEL_LEAVESRC=y

Without your fix my "localdir_nobuild" iso test release wouldn't have
worked right because my kernel module package expects that the kernel
source is unpacked in the BUILD directory so that it can utilize its
kbuild infrastructure.  So, I needed that part of the fix too.  It appears
that this CONFIG_PKG_KERNEL_LEAVESRC variable gets cleared every time you
run the LTIB.  Is this correct?  Why does the variable get cleared every
time?

Also, I think I've found one more bug.  In most of the
config/platform/%{ARHC}/main.lkc files, selecting
CONFIG_PKG_KERNEL_LEAVESRC does not imply selecting PKG_KERNEL_WANT_CF. 
However, for the platforms mpc8349itx and ep93xx the main.lkc files look
like:

config PKG_KERNEL_LEAVESRC
    depends ! KERNEL_NONE
    select PKG_KERNEL_WANT_CF
    bool "Leave the sources after building"
    default n
    help
      This is a one shot option that can be used to build the kernel and
      leave the build source tree in rpm/BUILD in place

I think the line "select PKG_KERNEL_WANT_CF" should be removed for correct
functionality and to match the majority of the other main.lkc files.


Thanks,

Aaron

> Hi Aaron,
>
> Agreed, after looking into this I'm going the change you suggest.
>
> Regards, Stuart
>
>
> address@hidden wrote:
>> The platform I'm using is mpc8349itx.  If I remove the file
>>
>> config/platform/mpc8349itx/.config
>>
>> then typing `./ltib` drops me to the configuration menu
>>
>> "LTIB: Freescale MPC8349E-mITX board"
>>
>> If I have the config file, `./ltib` proceeds with the build without
>> going
>> to the configuration menu.
>>
>> At first glance it seems like the config file you say should not be
>> created needs to be present to avoid the menu.  The patch I submitted
>> was
>> working for the localdir_nobuild special tag when applied to CVS
>> revision
>> 1.5 of bin/Ltibrelease.pm.
>>
>> Aaron
>>
>>> Hi Aaron,
>>>
>>> Please keep messages on the list.
>>>
>>> I agree that a platform should be pre-chosen, so the top level .config
>>> should be there.  I'll look at fixing this, but not sure when (feel
>>> free
>>> to submit another patch).  The reason your patch is not quite right is
>>> that the platform config should not be created (the one in
>>> config/platform/_target_).
>>>
>>> Regards, Stuart
>>>
>>> address@hidden wrote:
>>>> Hi Stuart, how's everything?
>>>>
>>>> I think I liked the old way or my modified version better, because at
>>>> least I would have an iso that I could mount, run `install`, change
>>>> directory to non-distributable-*, then run `ltib` to build the entire
>>>> release.
>>>>
>>>> With your newest modifications the iso is bundled without a .config in
>>>> the
>>>> base non-distributable-* directory, and running `ltib` only builds the
>>>> host packages, then drops me to the configuration menu.  This is less
>>>> like
>>>> a BSP, because it's not specific to my platform, and more like the
>>>> LTIB
>>>> itself, which can be used for lots of platforms.  I don't think the
>>>> configuration menu should be invoked at all, either in producing the
>>>> iso
>>>> with the localdir_nobuild tag, or when installing the BSP from the iso
>>>> onto another machine.
>>>>
>>>> Thanks,
>>>>
>>>> Aaron
>>>>
>>>>> Hi Aaron,
>>>>>
>>>>> That's not quite right, you don't want to do any building for
>>>>> "localdir_nobuild".  I've checked in a fix that I think addresses
>>>>> this.
>>>>>
>>>>> Regards, Stuart
>>>>>
>>>>> address@hidden wrote:
>>>>>> I would recommend the patch following the diff command for the test
>>>>>> release mode with the localdir_nobuild tag.  Instead of dropping the
>>>>>> user
>>>>>> to the configure screen, the LTIB should be using the preconfig file
>>>>>> config/platform/${ARCH}/defconfig to produce the test release iso
>>>>>> file.
>>>>>>
>>>>>>
>>>>>> $ diff -aur Ltibrelease.pm Ltibrelease.pm.noconfigscr
>>>>>> --- Ltibrelease.pm       2009-10-26 14:15:37.898242755 -0400
>>>>>> +++ Ltibrelease.pm.noconfigscr   2009-10-26 14:17:03.037301396 -0400
>>>>>> @@ -399,6 +399,8 @@
>>>>>>  if [  "$tag" != "localdir_nobuild" ]
>>>>>>  then
>>>>>>      ./ltib --preconfig $cf->{plat_dir} --configure --batch
>>>>>> +else
>>>>>> +    ./ltib --preconfig $cf->{plat_dir} -m config --batch
>>>>>>  fi
>>>>>>
>>>>>>  # copy the pre-built images if any to the iso so usable without
>>>>>> ltib
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> LTIB home page: http://ltib.org
>>>>>>
>>>>>> Ltib mailing list
>>>>>> address@hidden
>>>>>> http://lists.nongnu.org/mailman/listinfo/ltib
>>>>>>
>>>>
>>>>
>>
>>
>>
>>
>> _______________________________________________
>> LTIB home page: http://ltib.org
>>
>> Ltib mailing list
>> address@hidden
>> http://lists.nongnu.org/mailman/listinfo/ltib
>>
>