Re: [Ltib] Problem with "./ltib -e"

[Peter Barada]

On Thu, 2009-11-05 at 17:08 +0000, Stuart Hughes wrote:
> Hi Peter,
>
> Thanks for your patch. It will fix the problem and in this case given 
> the code there already it is probably the most direct and clear 
> solution.  I have checked-in this change.  I've tested with -e an 
> without and it fixes the issue you raise and doesn't seem to do any 
> (obvious) harm in other modes.

Glad it works for you.

> As you probably can see from the code in that area it really needs some 
> re-structuring.  The problem is that if that is done there would need to 
> be a lot of regression testing.
I noticed that, and picked that fix as what I thought would have a minimal impact on all the other use cases...

> Regards, Stuart
>
> Peter Barada wrote:
> > Stuart,
> > 
> > While using the latest LTIB, I noticed a difference in action from 
> > previous LTIB (8.4.1).
> > 
> > If I "sudo rm -rf rootfs; ./ltib -e" to repopulate the rootfs from 
> > scratch (to clean up from installed packages that are now deselected, 
> > etc), I noticed that the current ltib will not deploy of any package 
> > that is expanded into rpm/BUILD.  Since in my build I need the kernel 
> > sources around to build a module, the kernel will not be deployed by 
> > ./ltib -e.
> > 
> > The problem (I think) is in build_rpm with the following code:
> > 
> >                     # See if the source tree has been touched
> >                     $cmd = "find $src_dir -newer $rpms[0] -print";
> >                     print "checking if sources have been updated: ";
> >                     if(`$cmd`) {
> >                         print "yes\n";
> >                     } else {
> >                         print "no\n";
> >                         return 1;
> >                     }
> > 
> > 
> > If I patch LTIB with the following, the "./ltib -e" will deploy all the 
> > packages, whether they are expanded into rpm/BUILD or not:
> > 
> > address@hidden:~/work/logic/svn/eps_svn/software/products/linux/LTIB/trunk/ltib-20091102$ svn diff ltib
> > Index: ltib
> > ===================================================================
> > --- ltib	(revision 8401)
> > +++ ltib	(working copy)
> > @@ -841,7 +841,7 @@
> >                          print "yes\n";
> >                      } else {
> >                          print "no\n";
> > -                        return 1;
> > +                        goto CHECK_FOR_INSTALL;
> >                      }
> >                  }
> >                  warn "scbuild/scdeploy already unpacked package\n";
> > @@ -888,6 +888,8 @@
> >              return;
> >          }
> >      }
> > +
> > +CHECK_FOR_INSTALL:
> >      # short circuited rpm modes don't install rpms
> >      return 1 if $rpmopts =~ m,--short-circuit,;
> >  
> > 
> > Is this the right way to fix the problem of "./ltib -e" not deploying 
> > packages that are expanded into rpm/BUILD?
> > 
> > -- 
> > Peter Barada <address@hidden <mailto:address@hidden>>
> > Logic Product Development, Inc.
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > LTIB home page: http://ltib.org
> > 
> > Ltib mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/ltib

--
Peter Barada <address@hidden>
Logic Product Development, Inc.