[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] (was Re: [lwip-devel] pbuf_chain followed by pbuf_free )
From: |
Leon Woestenberg |
Subject: |
Re: [PATCH] (was Re: [lwip-devel] pbuf_chain followed by pbuf_free ) |
Date: |
Fri, 31 Oct 2003 14:29:53 +0100 (MET) |
Hello Jani,
> and here's the patch for review
>
The documentation scares me.
Please describe the pbuf functions more thoroughly. The invariables of
the pbuf struct (as documented in pbuf.h I think) are currently violated
in the documentation.
I think this is more appropriate: (RFC)
/* Concatenate pbuf (chain) tail after pbuf (chain) head and remove the
* reference of the caller to the tail pbuf (chain).
*
* @note The caller MUST NOT reference tail afterwards.
*
* @see pbuf_chain()
*
*/
pbuf_cat(head, tail)
/* Chain pbuf (chain) tail after pbuf (chain) head and maintain the
* reference of the caller to the tail pbuf (chain).
*
* @note The caller still references tail and must explicitly call
* pbuf_free() when it no longer uses the tail pbuf (chain).
*
* @see pbuf_cat()
*
*/
pbuf_chain(head, tail)
Leon.
--
NEU FÜR ALLE - GMX MediaCenter - für Fotos, Musik, Dateien...
Fotoalbum, File Sharing, MMS, Multimedia-Gruß, GMX FotoService
Jetzt kostenlos anmelden unter http://www.gmx.net
+++ GMX - die erste Adresse für Mail, Message, More! +++