[lwip-devel] [bug #19347] netif_add & tcpip_init problem

[Frédéric Bernon]

Follow-up Comment #31, bug #19347 (project lwip):

Ok, I join a ZIP file with two new files :

lwip/src/api/netifapi.c
lwip/src/include/lwip/netifapi.h

and the patch for tcpip.h/.c and opt.h.

Simon, any other comments about that (I just start test, but for the general
design)?

About your dhcp patch, just one thing: why in start/stop timers do you use
this protection :

+  SYS_ARCH_DECL_PROTECT(old_level);
+  SYS_ARCH_PROTECT(old_level);
...
+  SYS_ARCH_UNPROTECT(old_level);

You are in tcpip_thread context, and you just initialize sys_timeouts? What
is the risk?

Last, a detail, it will be better to my point of view to define 
DHCP_COARSE_TIMER_MSSECS to avoid to do "*1000" each time (even if most of
compilers will directly optimize that...

I think we are near of the end for this problem...


(file #12404)
    _______________________________________________________

Additional Item Attachment:

File name: netifapi.zip                   Size:4 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19347>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/