[lwip-devel] [bug #19222] timeout in sys_mbox_fetch

[Jonathan Larmour]

Follow-up Comment #18, bug #19222 (project lwip):

I have just two little comments on this change to sys_mbox_fetch. This
function is now hard to follow for sure, so I may have slipped up.
Nevertheless, in this block:

      if ((timeout) && (timeout<timeouts->next->time)) {
      /* If time == SYS_ARCH_TIMEOUT, and we have wait "fetch's timeout" and
not "timer's timeout",
         The timeout variable is the number of milliseconds we have waited
for the message. */
        if (timeout < timeouts->next->time) {
          timeouts->next->time -= timeout;
        } else {
          timeouts->next->time = 0;
        }

The last 'else' clause can never happen because the second 'if' is a subset
of the first 'if'. That test just shouldn't be there I think.

I have also added a little comment.

Is this ok by you Frederic? I don't use this code myself, but it's a tiny
change.


(file #12462)
    _______________________________________________________

Additional Item Attachment:

File name: sys.c.tweak.patch              Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19222>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/