lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [lwip-devel] [task #7142] Sanity check user-configurable values


From: Goldschmidt Simon
Subject: RE: [lwip-devel] [task #7142] Sanity check user-configurable values
Date: Wed, 5 Sep 2007 12:38:55 +0200

> in tcp.h:
> 
> #if TCP_WND > 0xffff
> #error TCP_WND must fit in an u16_t
> #endif
> 
> in etharp.h:
> 
> #if ARP_TABLE_SIZE > 0x7f
> #error ARP_TABLE_SIZE must fit in an s8_t #endif

Since those are directly related to the type of the array, I'd suggest
to leave them near the declaration. If someday the declaration type is
changed, it's more likely the test is also changed if it's directly
above the declaration...




reply via email to

[Prev in Thread] Current Thread [Next in Thread]