[lwip-devel] [patch #7088] DNS with custom malloc/realloc contains a double free in RAM pbuf realloc

[Simon Goldschmidt]

Follow-up Comment #2, patch #7088 (project lwip):

I do see problems here, for example in ip_input: at the start of the
function, iphdr is set to p->payload. That patch attached here reallocs the
pbuf but does *not* change all pointers that already point into p->payload!

There are certainly other places where this change will hurt. Also, I don't
think this change is really "lightweight": it leads to "realloc" using memcpy
for rx packets although this wouldn't be necessary.

I very strongly vote against this going in!! Instead, for such heap
implementations, mem_realloc should do nothing, as MEM_LIBC_MALLOC does!

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7088>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/