[lwip-devel] [bug #37166] memp_sanity check loops itself

[Simon Goldschmidt]

Follow-up Comment #3, bug #37166 (project lwip):

> if (n == m && --c < 0)
> 
> is not the same as
> if (n == m & --c < 0)
> 
> but is equivalent to
> if (n == m)
>   if (--c < 0)

Of course it is. But what's "cruel" about boolean operators?

That's what the code wants to do: when looping the inner loop, m==n may be
true exactly one time. If it's true more than once, we have a loop.

The problem is that we can have a loop without reaching m==n, so c is never
decremented.

I'll fix it by adding another counter that checks that considers "memp_num" as
maximum loop count.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?37166>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/