lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack b


From: Simon Goldschmidt
Subject: Re: [lwip-devel] [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. d43c092f171e683028e184af56333dab9ce79fcb
Date: Thu, 21 Jul 2016 13:51:51 +0200

Unfortunately, that change won't really work as ppp_opts.h is not included in all files where LWIP_ETHERNET is checked. Another idea would be to generate an #error if PPPOE_SUPPORT is enabled but LWIP_ETHERNET is not.
 
Simon
 
- Log -----------------------------------------------------------------
commit d43c092f171e683028e184af56333dab9ce79fcb
Author: Sylvain Rochet <address@hidden>
Date: Thu Jul 21 13:19:04 2016 +0200

PPP: restore PPPoE devices without Ethernet ARP support, i.e. PPPoE only devices

Ethernet support is required for PPPoE but Ethernet support is only set
by default in opt.h if ARP is enabled, which is wrong because the right
condition is ARP and/or PPPoE, unfortunately PPPOE_SUPPORT can't be used
in opt.h because it is not defined if ppp_opts.h is not included before
opt.h in user code.

Fixup the LWIP_ETHERNET configuration value in ppp_opts.h in order to
force Ethernet support if PPPoE is enabled.

Fixes: 3ad2ad2329 ("Remove reference to PPPOE_SUPPORT in opt.h - leads
to compile errors because it has no default definition (only in
ppp_opts.h)"

-----------------------------------------------------------------------

Summary of changes:
src/include/netif/ppp/ppp_opts.h | 5 +++++
1 file changed, 5 insertions(+)


hooks/post-receive
--
lwIP - A Lightweight TCPIP stack

_______________________________________________
lwip-commits mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lwip-commits

reply via email to

[Prev in Thread] Current Thread [Next in Thread]