Re: [lwip-devel] Question about unsent_oversize reset by zero length pcb in tcp_write()

[address@hidden]

Axel Lin wrote:
> Hi,
> tcp_write() allows a pcb with len=0.  (tcp_write_checks() return
> ERR_OK if len is 0)
> In this case, nothing add to pcb->unsent list and last_unsent->len is
> not changed
> but pcb->unsent_oversize will be set to 0.
> I'm wondering if this is correct or not. Comments?

No, that's not really correct, unless there are flags added (so data 
length is zero but still a segment is created).
In that case, it's OK to not add anything to the last segment.
I guess the dumb case of calling tcp_write() with len==0 and no flags 
has just not been thought of... Plus I don't know if it's worth 
optimizing for this...

Simon