[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF |
Date: |
Tue, 25 Apr 2017 04:12:14 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36 |
Update of bug #50694 (project lwip):
Status: Works For Me => None
_______________________________________________________
Follow-up Comment #7:
Ah, well I haven't tested that setting, sorry.
Forget the code in comment #5, pbuf_coalesce cannot be used here because 'p'
must not be freed (the ref belongs to the caller).
I've added 'pbuf_alloc_copy' for that and clarified LWIP_NETIF_TX_SINGLE_PBUF
int opt.h:
if (p->next != NULL) {
struct pbuf *q = pbuf_alloc_copy(PBUF_RAW, PBUF_RAM, p);
if (q == NULL) {
return ERR_MEM;
}
/* ATTENTION: do NOT free the old 'p' as the ref belongs to the caller! */
p = q;
}
We still could fix this bug here by not chaining pbufs to segments. I'd be
happy to get a patch for that :-)
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?50694>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Robin, 2017/04/01
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Simon Goldschmidt, 2017/04/05
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Robin, 2017/04/06
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Axel Lin, 2017/04/24
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Simon Goldschmidt, 2017/04/24
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Simon Goldschmidt, 2017/04/24
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Axel Lin, 2017/04/24
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF,
Simon Goldschmidt <=
- [lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF, Simon Goldschmidt, 2017/04/25