[lwip-devel] [patch #9331] PPP: ppp_singlebuf: Use pbuf_coalesce() instead of open-coded

[Simon Goldschmidt]

Follow-up Comment #3, patch #9331 (project lwip):

> Maybe we should just consider that packets queues will never 
> materialize, so p->len == p->tot_len and p->next == NULL are 
> exactly the same.

I think the *can* be used, but such usages should be limited to queue/unqueue
using special functions. At least the netif_loop code does so. But it does so
by manually changing the pbuf struct members and does not pass the queued
pbufs to any function.

So I'm OK with your proposal to see the two tests as equal. I even think this
is already done in several places.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9331>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/