[lwip-devel] [patch #9367] init: Correct minimal MEMP_NUM_SYS_TIMEOUT setting check

[Axel Lin]

Follow-up Comment #3, patch #9367 (project lwip):

Hi Sylvain,

Thanks for your comment.

In my case, I set MEMP_NUM_SYS_TIMEOUT to a too small value but it was not
cached by #error.
(I have AUTH + PAP|CHAP|EAP + LCP enabled)
I didn't figure out the problem until today I hit the assertion:
LWIP_ASSERT("sys_timeout: timeout != NULL, pool MEMP_SYS_TIMEOUT is empty",
timeout != NULL);

That is why I think the minimal MEMP_NUM_SYS_TIMEOUT setting check needs fix.

I'm wondering if it make sense to define LWIP_NUM_SYS_TIMEOUT_INTERNAL as
below:

#define LWIP_NUM_SYS_TIMEOUT_INTERNAL   (LWIP_TCP + IP_REASSEMBLY + LWIP_ARP +
(2 * LWIP_DHCP) + LWIP_AUTOIP + LWIP_IGMP + LWIP_DNS + \
                                         (PPP_SUPPORT * (1 + (PPP_AUTH_SUPPORT
* 2) + PPP_IPV4_SUPPORT + PPP_IPV6_SUPPORT + PPPOE_SUPPORT) *
MEMP_NUM_PPP_PCB) + \
                                         (LWIP_IPV6 ? (1 + LWIP_IPV6_REASS +
LWIP_IPV6_MLD) : 0))


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9367>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/