Re: [lwip-devel] build error: conversion to 'u32_t' from 'int' may change the sign of the result

[address@hidden]

Axel Lin wrote:
> I got below build error in current git tree:
>
> src/include/lwip/api.h:394:77: error: conversion to 'u32_t' from 'int'
> may change the sign of the result [-Werror=sign-conversion]
>   #define netconn_set_recvtimeout(conn, timeout)
> ((conn)->recv_timeout = (timeout))
>                                                                               ^
> Looks like commit 44f7a3cb0d87 ("work on -Wconversion...") changes int
> recv_timeout; to u32_t recv_timeout; causes this build error.

Yes, that was on purpose. Negative values are not supported and the 
value is directly passed to sys_arch_mbox_fetch(), where you'd normally 
get the conversion error (but it seems like you didn't, and we didn't 
either, because -Wconversion is still disabled).

I don't think there's much we can do to smoothen upgrading, or do you 
have a suggestion?

Simon