[lwip-devel] [patch #9558] tcpip: guard tcpip_msg enum/struct member with !CORE_LOCKING

[Joel Cunningham]

URL:
  <http://savannah.nongnu.org/patch/?9558>

                 Summary: tcpip: guard tcpip_msg enum/struct member with
!CORE_LOCKING
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Mon 05 Feb 2018 11:44:33 PM UTC
                Category: sockets/netconn
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: jcunningham
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

enum tcpip_msg_type and struct tcpip_msg have members which are only used when
core locking and/or core locking input are disabled. Remove these from the
union to reduce the size. Remove from enum to prevent usage when these are
options are disabled

A quick sizeof test with MSVC 2013 showed a 4 byte size reduction for struct
tcpip_msg (16 bytes -> 12bytes) for the following configuration:
  LWIP_TCPIP_CORE_LOCKING        1
  LWIP_TCPIP_CORE_LOCKING_INPUT  1
  LWIP_TCPIP_TIMEOUT             0

RFC on attached patch, thanks!



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 05 Feb 2018 11:44:33 PM UTC  Name:
0001-tcpip-guard-tcpip_msg-enum-struct-member-with-CORE_L.patch  Size: 2KiB  
By: jcunningham

<http://savannah.nongnu.org/patch/download.php?file_id=43186>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9558>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/