[lwip-devel] [patch #9665] Introduce lwip_toupper and use it in netbiosns.c

[Axel Lin]

URL:
  <http://savannah.nongnu.org/patch/?9665>

                 Summary: Introduce lwip_toupper and use it in netbiosns.c
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: axellin
            Submitted on: Wed 27 Jun 2018 07:17:49 AM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

I got below build warning if #define LWIP_NO_CTYPE_H 1.
So I'm wondering if it is required to introduce lwip_toupper
and implement it when LWIP_NO_CTYPE_H=1.

cc -g -DLWIP_DEBUG -Wall -pedantic -Werror -Wparentheses -Wsequence-point
-Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual
-Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align
-Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wunreachable-code
-Wuninitialized -Wmissing-prototypes -Wredundant-decls -Waggregate-return
-Wlogical-not-parentheses -Wlogical-op -Wc90-c99-compat -Wtrampolines -I.
-I../../.. -I../../../../lwip/src/include -I../../../ports/unix/port/include
-I../../../../mbedtls/include -Wno-redundant-decls -DLWIP_HAVE_MBEDTLS=1
-Wno-c90-c99-compat -c ../../../../lwip/src/apps/netbiosns/netbiosns.c
../../../../lwip/src/apps/netbiosns/netbiosns.c: In function
‘netbiosns_set_name’:
../../../../lwip/src/apps/netbiosns/netbiosns.c:502:37: error: implicit
declaration of function ‘toupper’ [-Werror=implicit-function-declaration]
     netbiosns_local_name[i] = (char)toupper((unsigned char)hostname[i]);
                                     ^~~~~~~
cc1: all warnings being treated as errors
/home/axel/git/lwip/lwip-contrib/ports/unix/../Common.allports.mk:91: recipe
for target 'netbiosns.o' failed
make: *** [netbiosns.o] Error 1




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 27 Jun 2018 07:17:49 AM UTC  Name:
0001-Introduce-lwip_toupper-and-use-it-in-netbiosns.c.patch  Size: 2KiB   By:
axellin

<http://savannah.nongnu.org/patch/download.php?file_id=44443>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9665>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/