[lwip-devel] [bug #54195] ethernet.c, 178 & 195: extra condition

[Andrey Vinogradov]

URL:
  <http://savannah.nongnu.org/bugs/?54195>

                 Summary: ethernet.c, 178 & 195: extra condition
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: andreyvinogradov
            Submitted on: Ср. 27 июня 2018 16:54:26
                Category: Network drivers
                Severity: 3 - Normal
              Item Group: Compiler Warning
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

At line 91:
  if (p->len <= SIZEOF_ETH_HDR) {
    ...
    goto free_and_return;
  }

Next at line 178 & 195:
if ((p->len < next_hdr_offset) || pbuf_remove_header(p, next_hdr_offset)) {
...
    goto free_and_return;
}

So p->len checks twice




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54195>

_______________________________________________
  Сообщение отправлено по Savannah
  https://savannah.nongnu.org/