[lwip-devel] [bug #59946] lwip_select: errno not set properly on error

[yuanjianmin]

URL:
  <https://savannah.nongnu.org/bugs/?59946>

                 Summary: lwip_select: errno not set properly on error
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: yuanjm
            Submitted on: Tue 26 Jan 2021 11:05:32 AM UTC
                Category: sockets/netconn
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: 2.1.1

    _______________________________________________________

Details:

Hi,
  i meet a problem about errno could not setted properly in lwip_select. I
found that originially lwip_selscan() only returned values >=0 and only since
this bugfix
commit(https://git.savannah.nongnu.org/cgit/lwip.git/commit/?id=3107d4a0fa95f93b55998bcccff1b3c66d959329)
it is possible that it returns -1. But this commit maybe not exactly correct.
In following two line code,
https://git.savannah.nongnu.org/cgit/lwip.git/tree/src/api/sockets.c#n2113 and
https://git.savannah.nongnu.org/cgit/lwip.git/tree/src/api/sockets.c#n2186, it
did not handle the case of returning -1. Maybe the possibility of -1 is
relatively low, but from the code logic, do we need to consider.
Thanks
yuanjm




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?59946>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/