[lwip-devel] [patch #10086] mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()

[Jonathan D]

URL:
  <https://savannah.nongnu.org/patch/?10086>

                 Summary: mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jona
            Submitted on: Wed 07 Jul 2021 08:54:04 AM UTC
                Category: apps
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

In mqtt.c, several LWIP_ASSERT_CORE_LOCKED are irrelevant. The most obvious is
in mqtt_client_new which just does a calloc.
I also found that LWIP_ASSERT_CORE_LOCKED in mqtt_client_is_connected and
mqtt_set_inpub_callback are useless but they are not included in the patch.

As a sidenote, I have a separate thread to manage MQTT, does this means that
each call to function with LWIP_ASSERT_CORE_LOCKED must be surrounded by
(UN)LOCK_TCPIP_CORE ?



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 07 Jul 2021 08:54:04 AM UTC  Name:
0001-mqtt.c-Remove-useless-LWIP_ASSERT_CORE_LOCKED.patch  Size: 710B   By:
jona

<http://savannah.nongnu.org/patch/download.php?file_id=51657>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10086>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/