[lwip-members] [bug #43514] SMTP authentication disabled when only LOGIN is enabled

[Uli Köhler]

URL:
  <http://savannah.nongnu.org/bugs/?43514>

                 Summary: SMTP authentication disabled when only LOGIN is
enabled
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: ulikoehler
            Submitted on: Sa 01 Nov 2014 23:48:58 GMT
                Category: Contrib
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.4.1

    _______________________________________________________

Details:

In lwip-contrib/apps/smtp/smtp.c (verified in git head and STABLE-1_4_1),
several code blocks including smtp_prepare_auth_or_mail() are enabled/disabled
using the following macro:

#if SMTP_SUPPORT_AUTH_AUTH || SMTP_SUPPORT_AUTH_LOGIN

I believe this is a typo and it should read: 

#if SMTP_SUPPORT_AUTH_PLAIN || SMTP_SUPPORT_AUTH_LOGIN

because SMTP_SUPPORT_AUTH_AUTH is defined nowhere and it clearly makes sense
to enable the code blocks if any of the both auth methods are enabled.

I'm trying to run the SMTP client with LOGIN auth disabled and my mailserver
shows that no authentication attempt is performed. 

Suggested fix:

Replace all occurences of "SMTP_SUPPORT_AUTH_AUTH" with
"SMTP_SUPPORT_AUTH_PLAIN" in smtp.c.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?43514>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/