[lwip-users] Re: [lwip] Memory leak and queued packets in etharp.c

[Martin . Glunz]

> Your suggestion to simplify the architecture a bit is OK, but adding
> stuff
> in the ARP module is _not_, IMHO
> 
> I think the better approach is to make an Ethernet module that is
> generic
> for all Ethernet drivers and implements the generic functionality of
> Ethernet drivers and the Ethernet-dependent stuff of ARP.
> 
I think, that will be ok. The current etharp.c seemed to be intended
for ethernet only, so I took the device-independent things there.

But you might have seen that I've changed some function returns
and made low_level_output() calls from etharp_input() and etharp_output().
The netif struct contains a function * for the link level output, I've
made use of this. So it isn't necessary anymore to pass pbuf * back
to the interface_output() and _input(). This way it is easier to
free the arp leftover pbuf and the queued pbufs, than passing their
pointers back to the driver.

> Then,  ARP should be made link layer independent (i.e. remove the
> little
> Ethernet dependency that is there) so that the complex functions can
> be re-used over different link media.
>
> These changes definitely should be done in a seperate branch as we
> want the current branch to stabilize.
Yes, thats ok if you plan to release a new Version soon. But I think
for the following release it should be integrated together with
dhcp and the link layer independency.
 
Martin Glunz

[This message was sent through the lwip discussion list.]