[lwip-users] ICMP reply in udp_input()

[Ed Sutter]

Hello again,
I noticed a while ago that in udp_input(), just after the
two loops that search for a pcb match, there is a line
commented out that I don't understand...

This line:
   if ((pcb != NULL) || (ip_addr_cmp(&inp->ip_addr,&iphdr->dest))
has been replaced with:
   if (pcb != NULL)

It appears that with the ip_addr_cmp test included, the
code will generate an ICMP error response as it should.
With this line commented out, it looks like packets that
come into the stack with the correct IP address but
no valid port are just dropped.

What's the history behind this change?
Ed

els.vcf
Description: Card for Ed Sutter