Re: [lwip-users] Compile errors with lwip 0.7.0 and contrib-20040122

[Peter Graf]

Jani Monoses wrote:

> > On my non-Unix/non-GCC target the mess due to the u_xxx definitions
> > was even bigger. Question to the maintainers: Wouldn't it be better to
> > use the generic lwip type definitions (u8_t, s8_t, ...) in the ppp
> > files also?
> >    
>
> yes I think it would.On the other hand the way it is currently
> makes it easier for merging from upstream (wherever that is) , the
> original sources Marc Boucher ported the code from.
>  
A reason that must be accepted :-)

> Doesn't that #ifndef u_whatever solve the problems for the ppp code?
>  
Not here. I had to manually fix more than a handful places in the PPP 
code. This also comes from some #if... that depend on the compiler's 
capabilities, so I guess no one else noticed. Sorry for being unprecise 
on this, but I have no access to my stuff for some time.

> It would still be easier to have the defines in place than to do a
> search and replace type of change..
>
>  
>
> > Another thing that has puzzled me a bit, is that sys_msleep() is now
> > forced to use the overhead of allocating and deallocating a semaphore
> > on every call. Wouldn't it be better to allow sys_msleep() to be
> > implemented in sys_arch.c?
> >    
>
> I remember looking at that long ago and I am not sure why but did not
> change anything. Maybe the fact that it uses lwip semaphores allows lwip
> timers to fire whereas a native sleep would not trigger the timers of
> the sleeping thread.You could check and see if that's the case, I'll do
> it with the ecos port sometime soon.
>  
IIRC that's not the case. So far sys_msleep() is only used for PPP, 
where native sleep had been working OK.

All the best
Peter