Re: [lwip-users] tcp_receive bugfix - incoming segment is larger than the old segment.

[Jonathan Larmour]

It looks like this patch hasn't been picked up. Can you submit it to 
https://savannah.nongnu.org/patch/?group=lwip please to be sure a developer 
(I'm not one) can act on it? Thanks.

Jifl

Oleg Tychev wrote:
> Hello, All!
>
> I see on this code fragment in function tcp_receive
>              if (inseg.len > next->len) {
>                /* The incoming segment is larger than the old
>                   segment. We replace the old segment with the new
>                   one. */
>                cseg = tcp_seg_copy(&inseg);
>                if (cseg != NULL) {
>                  cseg->next = next->next;
>                  if (prev != NULL) {
>                    prev->next = cseg;
>                  } else {
>                    pcb->ooseq = cseg;
>                  }
>                }
>                break;
>              } else {
> and think it should have free function for "next"
>
>              if (inseg.len > next->len) {
>                /* The incoming segment is larger than the old
>                   segment. We replace the old segment with the new
>                   one. */
>                cseg = tcp_seg_copy(&inseg);
>                if (cseg != NULL) {
>                  cseg->next = next->next;
>                  tcp_seg_free(next);
>                  if (prev != NULL) {
>                    prev->next = cseg;
>                  } else {
>                    pcb->ooseq = cseg;
>                  }
>                }
>                break;
>              } else {
>
> Poka poka
> -------------
> Oleg Tychev
>
>
>
>
> _______________________________________________
> lwip-users mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/lwip-users


--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
Visit us at Embedded World 2007, Nürnberg, Germany, 13-15 Feb, Stand 11-336
Company legal info, address and number:   http://www.ecoscentric.com/legal
------["The best things in life aren't things."]------      Opinions==mine