Re: [lwip-users] lwIP 1.3.1 : src IP chk drops DHCP (discover) packets

[Mandeep Sandhu]

On Mon, Sep 7, 2009 at 11:27 AM, Simon Goldschmidt<address@hidden> wrote:
>
> Could you please file a bug report on savannah to make sure this doesn't get 
> forgotten? I'm currently not in a position to check in code, so it might be 
> take while...

Done.

https://savannah.nongnu.org/bugs/index.php?27390

Hope the bug report is ok. I'm a first time user so might have missed something.

Thanks,
-mandeep

>
> Simon
>
>
>> All,
>>
>> Can this particular code section be removed? (this in context of this
>> thread)
>>
>> Or at least make it configurable?
>>
>> from ip.c:ip_input
>>
>> #if LWIP_DHCP
>>   if (check_ip_src)
>> #endif /* LWIP_DHCP */
>>   {  if ((ip_addr_isbroadcast(&(iphdr->src), inp)) ||
>>          (ip_addr_ismulticast(&(iphdr->src)))) {
>>       /* packet source is not valid */
>>       LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_TRACE | 1, ("ip_input: packet
>> source is not valid.\n"));
>>       /* free (drop) packet pbufs */
>>       pbuf_free(p);
>>       IP_STATS_INC(ip.drop);
>>       snmp_inc_ipinaddrerrors();
>>       snmp_inc_ipindiscards();
>>       return ERR_OK;
>>     }
>>   }
>>
>> It's causing the stack to drop packets with src IP as either
>> 255.255.255.255 or 0.0.0.0
>>
>> Thanks,
>> -mandeep
>>
>> >
>> > Yes, I see that bcast packets will be dropped right after this check
>> > (if we haven't found any netif yet).
>> >
>> > The only difference is that we are not incrementing the stats
>> > (IP_STATS_INC is missing) when we
>> > are dropping packets.
>> >
>> > -mandeep
>> >
>> >>
>> >> Simon
>> >> --
>> >> GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
>> >> Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01
>> >>
>> >>
>> >> _______________________________________________
>> >> lwip-users mailing list
>> >> address@hidden
>> >> http://lists.nongnu.org/mailman/listinfo/lwip-users
>> >>
>> >
>>
>>
>> _______________________________________________
>> lwip-users mailing list
>> address@hidden
>> http://lists.nongnu.org/mailman/listinfo/lwip-users
>
> --
> Jetzt kostenlos herunterladen: Internet Explorer 8 und Mozilla Firefox 3 -
> sicherer, schneller und einfacher! http://portal.gmx.net/de/go/chbrowser
>
>
> _______________________________________________
> lwip-users mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/lwip-users
>