[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FWD: Make CVS 7X slower on Win32 NTFS than beta 4
From: |
Eli Zaretskii |
Subject: |
Re: FWD: Make CVS 7X slower on Win32 NTFS than beta 4 |
Date: |
Sun, 12 Feb 2006 21:53:04 +0200 |
> From: "Markus Mauhart" <address@hidden>
> Date: Sun, 12 Feb 2006 15:37:43 +0100
>
> Function stat(..) is used at two additional places in dir.c, both times
> via macro EINTRLOOP, defined in make.h:
>
> /* Some systems (like Solaris, PTX, etc.) do not support the SA_RESTART flag
> properly according to POSIX. So, we try to wrap common system calls with
> checks for EINTR.....or you need to avoid -j.
> */
> #define EINTRLOOP(_v,_c) while (((_v)=_c)==-1 && errno==EINTR)
>
> Hence for consistency I would add a comparable loop here too.
If Paul wants to be consistent here, I don't mind, but EINTRLOOP is an
unnecessary complication on Windows, since `stat' (or any other
syscall, for that matter) cannot be interrupted there, ever. And
since we are talking about a code fragment which is conditionally
compiled only on Windows, I didn't see a reason to add a loop that
will be always executed exactly once.