Re: [Maposmatic-dev] [PATCH maposmatic 1/9] Improve the file cleanup mechanism

[Thomas Petazzoni]

On Wed, 3 Feb 2010 08:58:39 +0100
Maxime Petazzoni <address@hidden> wrote:

> * Thomas Petazzoni <address@hidden> [2010-02-02 22:19:06]:
> 
> > >   * files are now sorted by content modification time and not
> > > creation time (a simple chmod could mess up the order);
> > 
> > Are you sure ? Didn't you mix "modification" and "creation" in your
> > sentence ?
> 
> Sorry, let me rephrase: I now sort by content modification (st_mtime)
> instead of last metadata change (st_ctime).

Ok. In fact, I just discovered that the ctime was updated on metadata
changes. Until now, I thought it relly was the _creation_ time and
therefore never changed.

> You may be worried about the space occupied by the thumbnails after a
> while. We discussed this already, and a single Paris SVG rendering
> easily takes more disk space than hundreds of thumbnails. And the 80%
> of RENDERING_RESULT_MAX_SIZE foolproofs this, keeping space for
> thumbnails.
> 
> What do you think?

I'm not worried at all about the disk space. Simply about the
usefulness of this.

It is *completely* useless to show obsolete renderings on the
MapOSMatic website since we don't have the result of the rendering
anymore. Since we don't show obsolete renderings anywhere, I don't see
the point of keeping the thumbnails. To me, keeping the jobs in the
database is only useful for statistics purpose. So that ten years from
now, we can say that MapOSMatic has rendered 2379287398273 maps :-)

I really don't see *where* these thumbnails would be used.

> > When a rendering has been removed, it's not really longer "done",
> > in my opinion.
> 
> I don't share this opinion, but two against one, you win :-) I'll make
> the changes (they'll apply on top of this series).

Thanks!

Thomas
-- 
Thomas Petazzoni                         http://thomas.enix.org
Promouvoir et défendre le Logiciel Libre http://www.april.org
Logiciels Libres à Toulouse              http://www.toulibre.org

signature.asc
Description: PGP signature