[Mldonkey-bugs] [Bug #3296] [enhancement] why not use relative refs in HTML output?

[nobody]

=================== BUG #3296: LATEST MODIFICATIONS ==================
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=3296&group_id=1409

Changes by: Bernd Kischnick <address@hidden>
Date: Fri 05/16/2003 at 18:06 (GMT)

------------------ Additional Follow-up Comments ----------------------------
Thanks tharkun, for your very nice apache.conf hack!

for my apache I had to put "[P,L]" instead of "[P] [L]" at the end of the first 
RewriteRule.



=================== BUG #3296: FULL BUG SNAPSHOT ===================


Submitted by: kisch                   Project: mldonkey, a free e-Donkey client
Submitted on: Mon 04/21/2003 at 20:28
Category:  HTTP interface             Severity:  5 - Major                  
Bug Group:  None                      Resolution:  None                     
Assigned to:  None                    Status:  Open                         
Release:  None                        Release:  2.04rc1-0                   
Platform Version:  Linux i386-i686    Binaries Origin:  Downloaded from Savannah

Summary:  [enhancement] why not use relative refs in HTML output? 

Original Submission:  Hello, thanks for your great work!

Using relative refs in the generated HTML would enhance the possibilities to 
embed the mldonkey web interface into a larger apache setup.

If relative refs were used, a single apache ProxyPass directive would be 
sufficient to access the mldonkey web interface. As it is, the start frame 
contains requests to path-absolute URLs like e.g. /commands.html, so the 
following HTTP requests all need separate rewrite rules on their own.

And because the web browser assembles complete, absolute paths for the HTTP 
requests anyway from any relative path it sees in HTML, you wouldn't even have 
to change the HTTP request parsing code. Just drop the leading slashes from the 
output ;-)


Follow-up Comments
*******************

-------------------------------------------------------
Date: Fri 05/16/2003 at 18:06       By: kisch
Thanks tharkun, for your very nice apache.conf hack!

for my apache I had to put "[P,L]" instead of "[P] [L]" at the end of the first 
RewriteRule.

-------------------------------------------------------
Date: Tue 04/22/2003 at 07:42       By: tharkun
Im all for relative links but in the meantime, I use the following rewrite 
rules to not have to ProxyPass all URLs myself. This will make mldonkey 
available in /mldonkey on your apache.

RewriteCond      %{REQUEST_URI}           /mldonkey/.*
RewriteRule      .*/(.* ) http://www.my.dom:4080/$1 [P] [L]
# Rewrite the relative URI's mldonkey generates to use the /mldonkey/ prefix so 
the
# above rewrite rule can catch it.
RewriteCond      %{HTTP_REFERER}   .*apache.my.dom/mldonkey.* 
RewriteRule      .*/(.*) http://apache.my.dom/mldonkey/$1 [R]


CC List
*******

CC Address                          | Comment
------------------------------------+-----------------------------
address@hidden                       | 



No files currently attached


For detailed info, follow this link:
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=3296&group_id=1409