[Mldonkey-bugs] [bugs #3296] [enhancement] why not use relative refs in HTML output?

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #3296] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Thu 04/29/04 at 16:29 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | Wont Fix                  | None
              Status | Closed                    | Open


------------------ Additional Follow-up Comments ----------------------------
Reopened because fixing this would enable the html_mods interface to be used in 
a frame.






/**************************************************************************/
[bugs #3296] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=3296>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: Bernd Kischnick
On: Mon 04/21/03 at 20:28

Category:  HTTP interface
Severity:  5 - Average
Item Group:  None
Resolution:  None
Assigned to:  None
Status:  Open
Release:  None
Release:  2.04rc1-0
Platform Version:  Linux
Binaries Origin:  Binary from Savannah
CPU type:  None


Summary:  [enhancement] why not use relative refs in HTML output? 

Original Submission:  Hello, thanks for your great work!

Using relative refs in the generated HTML would enhance the possibilities to 
embed the mldonkey web interface into a larger apache setup.

If relative refs were used, a single apache ProxyPass directive would be 
sufficient to access the mldonkey web interface. As it is, the start frame 
contains requests to path-absolute URLs like e.g. /commands.html, so the 
following HTTP requests all need separate rewrite rules on their own.

And because the web browser assembles complete, absolute paths for the HTTP 
requests anyway from any relative path it sees in HTML, you wouldn't even have 
to change the HTTP request parsing code. Just drop the leading slashes from the 
output ;-)


Follow-up Comments
------------------


-------------------------------------------------------
Date: Thu 04/29/04 at 16:29         By: spiralvoice
Reopened because fixing this would enable the html_mods interface to be used in 
a frame.

-------------------------------------------------------
Date: Wed 02/25/04 at 01:15         By: spiralvoice
Here is some more information about Apache redirection:
http://mldonkey.berlios.de/modules.php?name=Wiki&pagename=ApacheRedirection

-------------------------------------------------------
Date: Fri 05/16/03 at 18:06         By: kisch
Thanks tharkun, for your very nice apache.conf hack!

for my apache I had to put "[P,L]" instead of "[P] [L]" at the end of the first 
RewriteRule.

-------------------------------------------------------
Date: Tue 04/22/03 at 07:42         By: tharkun
Im all for relative links but in the meantime, I use the following rewrite 
rules to not have to ProxyPass all URLs myself. This will make mldonkey 
available in /mldonkey on your apache.

RewriteCond      %{REQUEST_URI}           /mldonkey/.*
RewriteRule      .*/(.* ) http://www.my.dom:4080/$1 [P] [L]
# Rewrite the relative URI's mldonkey generates to use the /mldonkey/ prefix so 
the
# above rewrite rule can catch it.
RewriteCond      %{HTTP_REFERER}   .*apache.my.dom/mldonkey.* 
RewriteRule      .*/(.*) http://apache.my.dom/mldonkey/$1 [R]




CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
arutha --AT-- gmx --DOT-- de        | 









For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=3296>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/