[Mldonkey-bugs] [bugs #7593] mldonkey should not allow servers to be added more then 3 times with different ports

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #7593] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Sun 06/20/2004 at 17:38 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Duplicate
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Duplicate of bug 9357, please see patch mentioned there.






/**************************************************************************/
[bugs #7593] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7593>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Thu 02/05/2004 at 12:18

Category:  eDonkey-plugin
Severity:  5 - Average
Item Group:  Feature request
Resolution:  Duplicate
Assigned to:  None
Status:  Closed
Release:  2.5.4+[1-8]
Release:  2-5-4+2
Platform Version:  Linux
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  mldonkey should not allow servers to be added more then 3 times with 
different ports

Original Submission:  mldonkey should not allow servers to be added more then 3 
times with different ports

some disrupting clients seem to spread fake hosts with random ports ( mostly in 
the 61000-65000 range ) flooding the server list and disrupting connecting to 
servers.

i have not seen real working servers using more then 3 ports to allow 
connection and never in the high range.

i know using a static list will solve my problem but i rather use a dynamic list

autobanning such servers would be nice

also not allowing servers to use strange ports ( in the high range [ 
49152-65535 { dynamic or private ports } though most would see anything above 
10000 as the high range ] or well known ports [ irc, web, mail, SMB, rpc, 
telnet, ssh, ftp, etc... ] ) would make life easier

Follow-up Comments
------------------


-------------------------------------------------------
Date: Sun 06/20/2004 at 17:38       By: spiralvoice
Duplicate of bug 9357, please see patch mentioned there.

-------------------------------------------------------
Date: Tue 03/16/2004 at 09:52       By: artifex
I have the same problem. I look into the source but it seems that ocaml is not 
my language. :)

As I see MLD use a hash with ip _and_ port. Instead it's great if you use ip 
only hash and thereafter may compare the port. If the new ip exist drop it else 
add it. If you want to finetune apply this rules to the source exchange only. I 
think the ocbmaurice best server met file doesn't had any duplicates. In other 
words you give priority to the downloaded server met file instead of exchanged.

bye

-------------------------------------------------------
Date: Thu 03/04/2004 at 12:56       By: spiralvoice
Duplicate of bug 8001.

-------------------------------------------------------
Date: Fri 02/13/2004 at 10:56       By: None
i have not seen large servers using well known ports

a reason to run on a well known port to get through the firewall seems to me to 
mean that you dont have permission to run a server

plus allowing these ports would also mean you can ddos targets by spreading 
hosts with these ports to the network

-------------------------------------------------------
Date: Tue 02/10/2004 at 01:51       By: None
Some servers may use well known ports on purpose to try to get around some 
firewalls





CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
artifex                             | 









For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7593>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/