[Mldonkey-bugs] [bug #13712] ed2k_hash never completes for large files

[z]

Follow-up Comment #2, bug #13712 (project mldonkey):

I receive:

Fatal error: exception Unix.Unix_error(12, "os_read", "")

when trying to ed2k_hash 2+ gig files at the bitprint part (sha1 and
tigertree).  I also think that I noticed an infinite loop in tiger_block_size
when the int is overflowed.

This is obviously all due to the use of ints.  

Attached is a patch I used to switch to size_t and tested on small files, 2
gig files, and 4.5 gig files. All seem to work for me now.  Tested on linux
and cygwin (haven't tried mingw) with mld 2.6.3.
  
The hash results still match bitzi bitcollider and ed2k-tools.sf.net's
ed2khash app, but both of those apps fail on files > 2 gigs.  I don't know of
another app with which to compare.      
    _______________________________________________________

Additional Item Attachment:

File name: size_t.diff                    Size:6 KB

<http://savannah.nongnu.org/bugs/download.php?item_id=13712&item_file_id=2856>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=13712>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/