Re: Random notes

[Jan-Henrik Haukeland]

Christian Hopp <address@hidden> writes:

> * I have started a PLATFORMS file describing the quirks of our
>   different supported platforms.  So far I have included GNU/Linux
>   (glibc/uClibc/dietlibc) and Solaris (gcc/Forte).

Good idea! I would guess Rory can contribute interesting stuff here.

> * We should think about splitting monit.1 into monit.1 and monitrc.5.

Again a good idea! I'm planing on cleaning up monit.pod now, but I do
probably not have time to do the split. (But I'll put it in the back
of my head). I'm realy focused on cleaning up stuff and create a beta
release ASAP, since we are almost there and I'm running out of time
for working with monit now.

> * I have compiled monit with "gcc -pedantic".  It shows some
>   meaningful warnings and maybe you have some ideas how we should deal
>   with these rather strange issues...
>
>   1) strftime and %z
>
>      e.g. Solaris officially doesn't do %z either but it does
>      silently.  %z is a GNU extension.  So we have to find a different
>      solution to be portable!  

Ah, using %z is pretty convenient. It's so convinient that it is
tempting to let it stand :) Also because 99.9% will build monit with
glibc. (It's a pretty pragmatic viewpoint, I know, but from time to
time it pays to be a bit pragmatic :-|)= <- My new appearance with a
goatee.

>   2) .*printf and format strings... e.g.
>
> (...)
> gcc -pedantic -c -g -O2 -Wall -D _REENTRANT -I/usr/include -DLINUX  -I.
>   -I./device -I./http -I./process -I./protocols monitor.c -o monitor.o
> monitor.c: In function `help':
> monitor.c:772: warning: string length `825' is greater than the
>    length `509' ISO C89 compilers are required to support
> monitor.c:754: warning: string length `824' is greater than the length
>    `509' ISO C89 compilers are required to support
> (...)
>
>      Funny, or?  But some compilers might have limited length format
>      strings.

Interesting, it's worth to take notice of. (BTW, I saw Martin has
fixed this in the cvs).

-- 
Jan-Henrik Haukeland