monit-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: monit/protocols ntp3.c


From: Jan-Henrik Haukeland
Subject: Re: monit/protocols ntp3.c
Date: Fri, 28 Jan 2005 22:26:31 +0100


On Jan 28, 2005, at 22:18, Martin Pala wrote:

Jan-Henrik Haukeland wrote:
On Jan 28, 2005, at 18:55, Martin Pala wrote:
Log message:
    Add Michel Marti's NTP protocol test.
Hmm, we should really have fixed the check_udp_socket() first and change the patch and remove the code for *not* checking if a udp socket was ready. I.e. fix the root cause and not allow the workaround. Anyway, now that it is checked-in we'll just have to fix the patch-code afterwards when we have a proper check_upd_socket implementation.

I forgot to mention that i omited the workaround introduced in the patch (current monit check_udp_socket behavior is kept even with ntp3 patch integration).

Thanks for the explanation, I thought for a moment I was in the twilight zone :-) Good decision and the test will probably work anyway? We can fix check_upd_socket later.

--
Jan-Henrik Haukeland
Mobil +47 97141255





reply via email to

[Prev in Thread] Current Thread [Next in Thread]