Re: [monit-dev] New bug for file event empty or corrupt

[Francisco Javier Félix Belmonte]

I see bug #21550, but
if(!(version = File_readQueue(file, &size)) || size != sizeof(int)) {

when File_readQueue return FALSE, it not reserved memory and not free with FREE(version)
and correct the order to free mem of all File_readQueue


El dom, 24-08-2008 a las 10:19 +0200, Martin Pala escribió:
> Thanks for patch :)
>
> The problem should be fixed in upcoming monit 5.0 already, excerpt  
> from 5.0_beta1 changelog:
>
> --8<--
> * Fixed #21550: Fix crash when monit event queue contained an
>    empty file. Thanks to Douglas J Hunley for report.
> --8<--
>
>
>
> Thanks again for your work, we appreciate your input very much :)
>
> Martin
>
>
> P.S. the cvs version contains many changes and fixes ... i recommend  
> the cvs version for development:
> http://savannah.nongnu.org/cvs/?group=monit
>
>
>
> On Aug 24, 2008, at 9:41 AM, Francisco Javier Félix Belmonte wrote:
>
> > I found a bug when in /var/monit event file is empty or corrupt
> >
> > Attatch the fix
> >
> > Bye
> >
> > <basedir.diff>_______________________________________________
> > monit-dev mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/monit-dev
>
>
>
> _______________________________________________
> monit-dev mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monit-dev
>
> !DSPAM:48b119d4277784100413569!