monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Monotone-devel] Small bug found with cvs_import


From: Richard Levitte - VMS Whacker
Subject: [Monotone-devel] Small bug found with cvs_import
Date: Fri, 30 Jul 2004 16:51:01 +0200 (CEST)

Hi again,

after looking around in the code, I noticed that the associative array
of symbols had the symbol name as the key, but that searches in it was
done with revisions.  It's clear to me that this array should be
indexed with revisions, not symbol names, and have the name as value.

The included one-line patch fixes that little problem.

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte   \ Tunnlandsvägen 52 \ address@hidden
address@hidden  \ S-168 36  BROMMA  \ T: +46-708-26 53 44
                    \      SWEDEN       \
Procurator Odiosus Ex Infernis                -- address@hidden
Member of the OpenSSL development team: http://www.openssl.org/

-----------------------------------------------------------------
A: Because it fouls the order in which people normally read text. 
Q: Why is top-posting such a bad thing? 
A: Top-posting. 
Q: What is the most annoying thing on usenet and in e-mail?
# Old manifest: 8862b8549462c69fa8042ce3e147eadab3084e2f
# New manifest: 99531f5f3e4739efbcd95cb2a2b9b997737f7a2f
# Summary of changes:
# 
#   patch rcs_file.cc
#    from 46e600b4a32dda09ca4cb1d601cff377be6cb376
#      to d7dcbdf4b7deb457507bf08579b9832676f11e45
# 
--- rcs_file.cc
+++ rcs_file.cc
@@ -380,7 +380,7 @@
       { 
        std::string stmp, ntmp;
        sym(stmp); colon(); num(ntmp); 
-       r.admin.symbols.insert(make_pair(stmp, ntmp));
+       r.admin.symbols.insert(make_pair(ntmp, stmp));
       } 
     semi();
     expect("locks"); while(symp()) { sym(); colon(); num(); } semi();

reply via email to

[Prev in Thread] Current Thread [Next in Thread]