monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [patch]move attributes on rename


From: Joel Reed
Subject: Re: [Monotone-devel] [patch]move attributes on rename
Date: Tue, 26 Apr 2005 15:44:23 -0400
User-agent: Mutt/1.5.5.1i

On Tue, Apr 26, 2005 at 12:07:09PM -0700, Nathaniel Smith wrote:
> On Tue, Apr 26, 2005 at 02:15:58PM -0400, Joel Reed wrote:
> > I coded up the move attributes on rename functionality and
> > fixed the testcase tests/t_rename_attr.at.
> > 
> > I'll commit this if no one finds fault in the code.
> 
> Running out the door, so no time to read carefully now, but before I
> forget, does it do something sensible if the target filename already
> has some attributes on it?  (Something sensible probably means "don't
> silently delete them".)

ok, i guess now that we always drop attributes on drop file,
if there were attributes on the target filename, you would have
to add them after moving or copying the file, but before monontone rename.
but why would anyone do that if monotone rename does the right thing anyway?

what do you think? what am i missing?

jr




reply via email to

[Prev in Thread] Current Thread [Next in Thread]