Re: [Monotone-devel] [PATCH] Include()/Includedir() lua functions, --rcfile=directory

[Derek Scherger]

rghetta wrote:
> Monotone has two levels of configuration files, a per-workdir
> MT/monotonerc and a per-user ~/.monotone/monotonerc.
> Often is necessary to have also a per-site customization or simply share
> part of the configuration beetween developers (for example, a library of
> lua "snippets").
> Loading all scripts contained in a specific directory is also a common.

having read that I was expecting you would have added /etc/monotonerc
or something.

> To support these use case, this patch adds two new lua functions:
> include(<filename>) and includedir(<path>)
> The first function works like --rcfile, while the latter receives a path
> and loads all scripts contained there, in alphabetical order.
> The --rcfile option now also accept a directory as argument, with the
> same effect.

what's up with the big whitespace diff? personally I would prefer to see
big reformatting patches not mixed in with functionality change patches
just 'cuz they're kinda hard on the eyes.

also, was the change to the comment in commands.cc just to make gcc
happy? I'm guilty of adding that comment a while ago and I do recall
seeing a gcc warning about it. I'm surprised that I didn't clean it up
before committing actually but I must have missed it. I'll commit a fix
for this in another change I'm working on if you like. thanks for
catching it, ccache has kept me blissfully ignorant I guess.

I don't have any general feeling for whether I want these functions or
not myself (which is in no way an objection). hopefully someone else
will have more to say about them.

Cheers,
Derek