Re: [Monotone-devel] Re: Interesting bug in French locale :-)

[Nathaniel Smith]

On Mon, Sep 12, 2005 at 08:38:33PM +0200, Beno?t Dejean wrote:
> here's a possible fix for this bug : i've added ticker::id to store the
> unique identifier of each ticker. using N_() then _() would be another
> solution, but i think it would be harmful to do so. That's why i stored
> id and name seperately. ticker::id gets initialized with a
> locale-independant string. As i've added ticker::id, i've turned the
> tickers set from map<string, ticker*> to set<ticker*> which make more
> sense. Notice that ticker::id and tickers as a set are only used for
> sanity checks.

Why provide a string ticker::id at all?  It's just something to
copy-paste error on... why not identify tickers by their memory
address, or some unique id generated at construction time?  (E.g., a
global counter that's incremented each time one is made?)

-- Nathaniel

-- 
"...All of this suggests that if we wished to find a modern-day model
for British and American speech of the late eighteenth century, we could
probably do no better than Yosemite Sam."