monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Re: monotone disapprove does not give correct branc


From: Emile Snyder
Subject: Re: [Monotone-devel] Re: monotone disapprove does not give correct branch cert
Date: Tue, 25 Oct 2005 11:20:22 -0700

On Tue, 2005-10-25 at 18:50 +0100, Bruce Stephens wrote:
> Emile Snyder <address@hidden> writes:
> > I would argue that only commit should default to using the working copy
> > value if one is set.  approve and disapprove both take a revision as a
> > specific argument; I can sort of see using the value of the working copy
> > branch if that given revision has no branch cert, but not the other way
> > around.
> 
> I'm unconvinced that disapprove ought to do that.  Surely it ought to
> use the branches that are on the original revision, maybe giving a
> warning if there aren't any?  (I guess branchless revisions are
> unusual enough to merit at least a warning?)  Overridable by the
> --branch option, I guess.

I'm good with that.

thanks,
-emile

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]